Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450Ab0DYRB5 (ORCPT ); Sun, 25 Apr 2010 13:01:57 -0400 Received: from 26.mail-out.ovh.net ([91.121.27.225]:45713 "HELO 26.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752231Ab0DYRB4 (ORCPT ); Sun, 25 Apr 2010 13:01:56 -0400 Message-ID: <4BD4757E.8020503@example.com> Date: Sun, 25 Apr 2010 19:01:50 +0200 From: Piotr Hosowicz Reply-To: piotr@hosowicz.com Organization: hosowicz.com User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100411 Icedove/3.0.4 MIME-Version: 1.0 To: sedat.dilek@gmail.com CC: Sedat Dilek , Eric Dumazet , LKML , netdev@vger.kernel.org, David Miller , Jiri Olsa , Jongman Heo Subject: Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] References: <4BD45E68.4080900@example.com> <4BD46F9C.5060500@example.com> <1272213597.2069.32.camel@edumazet-laptop> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 8466485825827008928 X-Ovh-Remote: 83.6.189.87 (abaz87.neoplus.adsl.tpnet.pl) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-Spam-Check: DONE|U 0.5/N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2968 Lines: 84 On 25.04.2010 18:55, Sedat Dilek wrote: > Rebuild ipv6 kernel-modules by: > > $ make M=net/ipv6 > > ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually > to the right place. > > Applied your patch (seen on netdev ML) already and booted into new kernel. > Works, thanks. > > Tested-by: Sedat Dilek > > - Sedat - > > On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet wrote: >> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >>> On 25.04.2010 18:31, Sedat Dilek wrote: >>>> [ CCing netdev ML ] >>>> >>>> Confirmed: The revert-patch [1] fixes the problem here. >>> >>> I confirm, I've built a git6 kernel and it works fine. >>> >>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. >>>> >>>> Feel free to add a... Tested-by: Sedat Dilek >>> >>> I added created and tested phrase in my archive. ;-) Thank you a lot. I >>> hope there will be no this error in git7. >>> >> >> Did you test the proposed fix ? Eric, but where to get the proposed fix as a patch? I looked at kernel's bugzilla and there is no such thing. As for now I applied Sedat's reverse patch and now I am booted fine in git6 kernel. Regards, Piotr Hosowicz >> [PATCH] ipv6: Fix inet6_csk_bind_conflict() >> >> Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) >> introduced a bug on IPV6 part. >> We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but >> ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is >> IPV6. >> >> Reported-by: Michael S. Tsirkin >> Signed-off-by: Eric Dumazet >> --- >> diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c >> index b4b7d40..3a4d92b 100644 >> --- a/net/ipv6/inet6_connection_sock.c >> +++ b/net/ipv6/inet6_connection_sock.c >> @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, >> ipv6_rcv_saddr_equal(sk, sk2)) >> break; >> else if (sk->sk_reuse&& sk2->sk_reuse&& >> - !ipv6_addr_any(inet6_rcv_saddr(sk2))&& >> + !ipv6_addr_any(inet6_rcv_saddr(sk))&& >> ipv6_rcv_saddr_equal(sk, sk2)) >> break; >> } >> >> >> -- "Bardzo fajna firma, tylko czasami nie płaci. Do jej głównych zalet należą: ekspres ciśnieniowy (ale tylko na jednym z pię- ter) oraz fajne widoki z salki konferencyjnej. No i jakieś pół roku temu odeszło 90% pracowników działu IT, ale może nie mieli racji ;)" NP: Chickenfoot - Soap On A Rope NB: 2.6.34-rc5-git6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/