Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240Ab0DZMtN (ORCPT ); Mon, 26 Apr 2010 08:49:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10962 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621Ab0DZMtM (ORCPT ); Mon, 26 Apr 2010 08:49:12 -0400 Date: Mon, 26 Apr 2010 09:48:15 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Ingo Molnar , lkml , Paul Mackerras , Peter Zijlstra , Mike Galbraith , Frederic Weisbecker , systemtap , DLE Subject: Re: [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo Message-ID: <20100426124815.GD7460@ghostprotocols.net> References: <20100421195616.24664.89980.stgit@localhost6.localdomain6> <20100421195624.24664.46214.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100421195624.24664.46214.stgit@localhost6.localdomain6> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2252 Lines: 63 Em Wed, Apr 21, 2010 at 03:56:24PM -0400, Masami Hiramatsu escreveu: > Fix perf probe to use symtab only if there is no debuginfo, > because debuginfo has more precise information than symtab. "more precise"? Wouldn't it be "more expressive", i.e. with more information (parameter list with types, return type, location of parameters, etc), because what is common to both have the same value, i.e. the function address and size. > If we can't find a function in debuginfo, we never find it > in symtab. > > Signed-off-by: Masami Hiramatsu > Reported-by: Arnaldo Carvalho de Melo > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Mike Galbraith > Cc: Frederic Weisbecker > Cc: Ingo Molnar > --- > > tools/perf/util/probe-event.c | 17 +++++++++-------- > 1 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 4fb4803..5d3baec 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -180,15 +180,16 @@ static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, > return -ENOENT; > } > /* Error path : ntevs < 0 */ > - if (need_dwarf) { > - if (ntevs == -EBADF) > - pr_warning("No dwarf info found in the vmlinux - " > - "please rebuild with CONFIG_DEBUG_INFO=y.\n"); > - return ntevs; > + pr_debug("An error occurred in debuginfo analysis (%d).\n", ntevs); > + if (ntevs == -EBADF) { > + pr_warning("Warning: No dwarf info found in the vmlinux - " > + "please rebuild kernel with CONFIG_DEBUG_INFO=y.\n"); > + if (!need_dwarf) { > + pr_debug("Trying to use symbols.\nn"); > + return 0; > + } > } > - pr_debug("An error occurred in debuginfo analysis." > - " Try to use symbols.\n"); > - return 0; > + return ntevs; > } > > #define LINEBUF_SIZE 256 > > > -- > Masami Hiramatsu > e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/