Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920Ab0DZNai (ORCPT ); Mon, 26 Apr 2010 09:30:38 -0400 Received: from mail-ew0-f220.google.com ([209.85.219.220]:34941 "EHLO mail-ew0-f220.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984Ab0DZNag (ORCPT ); Mon, 26 Apr 2010 09:30:36 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=FniumzMb43nknuuwmrWkkT7sI61NoaDtdV+6h7eyQCursEiNcQY0fGN2z4qbQDMLOx mRhDVtuJSRZTra3Mb5+7GSoBOmDqRAN2ckRFTIv2LGpbegjdrE6HHUWBmv0dktb2j4RM 2LPp+NoBtPSAhKwUqhAtsvmLXTkrh3PUVk8jU= MIME-Version: 1.0 In-Reply-To: <201004261515.56750.arnd@arndb.de> References: <1272191830-23675-1-git-send-email-abogani@texware.it> <201004261406.50107.oneukum@suse.de> <201004261515.56750.arnd@arndb.de> Date: Mon, 26 Apr 2010 15:30:34 +0200 X-Google-Sender-Auth: 218bbc6ee2df9b7c Message-ID: Subject: Re: [PATCH] USB: sisusbvga: Remove the BKL from open From: Alessio Igor Bogani To: Arnd Bergmann Cc: Oliver Neukum , Greg Kroah-Hartman , Thomas Winischhofer , Mauro Carvalho Chehab , Pete Zaitcev , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Fr??d??ric Weisbecker" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 23 Dear Mr. Bergmann, 2010/4/26 Arnd Bergmann : >> >> BKL is not needed here because necessary locking is already provided >> >> by mutex sisusb->lock. [...] > What about the BKL in the sisusb_ioctl()? It seems to follow the > same logic, so I would think that you can simply remove the BKL > from the module entirely, rather than only half of it. It is what effectively I'm trying to do! The first part of this work is already present in USB subsystem maintainer tree (aka greg) at: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/usb/usb-sisusbvga-remove-the-bkl-from-ioctl.patch Ciao, Alessio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/