Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753952Ab0DZQ4R (ORCPT ); Mon, 26 Apr 2010 12:56:17 -0400 Received: from sj-iport-4.cisco.com ([171.68.10.86]:31561 "EHLO sj-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251Ab0DZQ4Q (ORCPT ); Mon, 26 Apr 2010 12:56:16 -0400 Authentication-Results: sj-iport-4.cisco.com; dkim=neutral (message not signed) header.i=none X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAEJi1UurR7Hu/2dsb2JhbACcPHGoa5l7hQsEgzk X-IronPort-AV: E=Sophos;i="4.52,274,1270425600"; d="scan'208";a="120737758" From: Roland Dreier To: Randy Dunlap Cc: James Bottomley , Ravi Anand , Andrew Morton , Linus Torvalds , linux-scsi , linux-kernel@vger.kernel.org, David C Somayajulu , Karen Higgins , Vikas Chaudhary Subject: Re: [PATCH 3rd_time] scsi: fix operator precedence warning References: <1271945825.2889.138.camel@mulgrave.site> <20100422110214.e7c62688.randy.dunlap@oracle.com> X-Message-Flag: Warning: May contain useful information Date: Mon, 26 Apr 2010 09:56:12 -0700 In-Reply-To: <20100422110214.e7c62688.randy.dunlap@oracle.com> (Randy Dunlap's message of "Thu, 22 Apr 2010 11:02:14 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 16 > - *tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16; > + *tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16); I wonder why we need that cast at all? The fact that tcp_source_port_num is a uint16_t* should cause the value to get truncated properly anyway. But I agree that this patch is a minimal fix for a real bug. -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/