Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882Ab0DZRBb (ORCPT ); Mon, 26 Apr 2010 13:01:31 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:59875 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451Ab0DZRBa (ORCPT ); Mon, 26 Apr 2010 13:01:30 -0400 Date: Mon, 26 Apr 2010 19:01:28 +0200 From: Jens Axboe To: =?iso-8859-1?Q?J=F6rn?= Engel Cc: Linus Torvalds , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Paolo Minazzi Subject: Re: [PATCH 1/2] [MTD] Move mtd_bdi_*mappable to mtdcore.c Message-ID: <20100426170128.GO27497@kernel.dk> References: <20100422162709.GJ27497@kernel.dk> <20100422203358.GB30749@logfs.org> <20100423100532.GN27497@kernel.dk> <20100423205518.GB7008@logfs.org> <20100426094810.GE27497@kernel.dk> <20100426143253.GB4364@logfs.org> <20100426143803.GM27497@kernel.dk> <20100426144532.GN27497@kernel.dk> <20100426163050.GC4364@logfs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100426163050.GC4364@logfs.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 31 On Mon, Apr 26 2010, J?rn Engel wrote: > On Mon, 26 April 2010 16:45:32 +0200, Jens Axboe wrote: > > > > Took a quick look, and you want bdi_setup_and_register() for the three > > bdis listed in mtdbdi.c in mtdcore.c:init_mtd(). Or manual bdi_init() > > and bdi_register(). I'll take a look post-dinner. Either is workable, > > but since the flags are already setup, the latter may be cleaner. > > Ok, here are two patches that appear to solve the problem for me. > > diff --git a/drivers/mtd/devices/drais.c b/drivers/mtd/devices/drais.c > index b93ff3f..6f81b28 100644 > --- a/drivers/mtd/devices/drais.c > +++ b/drivers/mtd/devices/drais.c > @@ -33,7 +33,7 @@ > #include > #include "drais.h" > > -#undef DEBUG_ERASE > +#define DEBUG_ERASE Leftover debugging? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/