Date: Mon, 26 Apr 2010 23:03:52 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: pavan_savoy@ti.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, npelly@google.com,
       pavan_savoy@yahoo.co.in
Subject: Re: [PATCH] drivers:staging: sources for ST core
Message-ID: <20100426230352.1564ef0f@lxorguk.ukuu.org.uk>
In-Reply-To: <1270750619-19174-3-git-send-email-pavan_savoy@ti.com>
References: <1270750619-19174-1-git-send-email-pavan_savoy@ti.com>
	<1270750619-19174-2-git-send-email-pavan_savoy@ti.com>
	<1270750619-19174-3-git-send-email-pavan_savoy@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 22


> +/* function pointer pointing to either,
> + * st_kim_recv during registration to receive fw download responses
> + * st_int_recv after registration to receive proto stack responses
> + */
> +void (*st_recv) (void*, const unsigned char*, long);

You still need a context of some kind as I said before to avoid thse
globals and single device limits.

And all the other issues - no explanation of the locking etc don't seem
to have been touched either.

I don't really see how I am supposed to review this stuff when the
locking and flow control assumptions are completely opaque

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/