Subject: Re: [PATCH 1/2] microblaze: add stack unwinder
From: "Steven J. Magnani" <steve@digidescorp.com>
Reply-To: steve@digidescorp.com
To: monstr@monstr.eu
Cc: microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org
In-Reply-To: <4BC5F11C.3080305@monstr.eu>
References: <1271220928-3502-1-git-send-email-steve@digidescorp.com>
	 <4BC5F11C.3080305@monstr.eu>
Content-Type: text/plain
Organization: Digital Design Corporation
Date: Mon, 26 Apr 2010 22:31:29 -0500
Message-Id: <1272339089.17476.1.camel@iscandar.digidescorp.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1559
Lines: 42

On Wed, 2010-04-14 at 18:45 +0200, Michal Simek wrote:
> > diff -uprN a/arch/microblaze/kernel/traps.c
> b/arch/microblaze/kernel/traps.c
> > --- a/arch/microblaze/kernel/traps.c  2010-04-09 21:52:36.000000000
> > +++ b/arch/microblaze/kernel/traps.c  2010-04-12 22:16:01.000000000 
[snip]
> >  
> > -     if (!stack)
> > -             stack = (unsigned long *)&stack;
> > +     if (fp == 0) {
> > +             if (task)
> > +                     fp = ((struct thread_info *)
> > +                             (task->stack))->cpu_context.r1;
> > +             else {
> > +                     /* Pick up caller of dump_stack() */
> > +                     fp = (__u32)&sp - 8;
> > +             }
> > +     }
> 
> just coding style.
> 
>         if (fp == 0)
>                 if (task)
>                         fp = ((struct thread_info *)
>                                 (task->stack))->cpu_context.r1;
>                 else
>                         /* Pick up caller of dump_stack() */
>                         fp = (__u32)&sp - 8;

Do you feel strongly about this? I try to always use braces on if/else
clauses that have more than one line. I've found that the extra
characters are well worth the savings in debugging time when someone
tries to extend the clause and forgets to add the braces.

Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/