Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753540Ab0D0Hwc (ORCPT ); Tue, 27 Apr 2010 03:52:32 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:38617 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248Ab0D0Hwa (ORCPT ); Tue, 27 Apr 2010 03:52:30 -0400 Date: Tue, 27 Apr 2010 09:52:29 +0200 From: Jens Axboe To: =?iso-8859-1?Q?J=F6rn?= Engel Cc: Linus Torvalds , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Paolo Minazzi Subject: Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register() Message-ID: <20100427075229.GB27497@kernel.dk> References: <20100423100532.GN27497@kernel.dk> <20100423205518.GB7008@logfs.org> <20100426094810.GE27497@kernel.dk> <20100426143253.GB4364@logfs.org> <20100426143803.GM27497@kernel.dk> <20100426144532.GN27497@kernel.dk> <20100426163050.GC4364@logfs.org> <20100426163126.GD4364@logfs.org> <20100426170247.GP27497@kernel.dk> <20100426171236.GG4364@logfs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100426171236.GG4364@logfs.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2067 Lines: 64 On Mon, Apr 26 2010, J?rn Engel wrote: > On Mon, 26 April 2010 19:02:48 +0200, Jens Axboe wrote: > > On Mon, Apr 26 2010, J?rn Engel wrote: > > > Otherwise we hit a BUG_ON in bdi_queue_work(). > > > > > > Signed-off-by: Joern Engel > > > --- > > > drivers/mtd/mtdcore.c | 17 ++++++++++++++++- > > > 1 files changed, 16 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > > > index cb4858b..8dd3e46 100644 > > > --- a/drivers/mtd/mtdcore.c > > > +++ b/drivers/mtd/mtdcore.c > > > @@ -322,6 +322,12 @@ int add_mtd_device(struct mtd_info *mtd) > > > if (!mtd_table[i]) { > > > struct mtd_notifier *not; > > > > > > + err = bdi_register(mtd->backing_dev_info, NULL, "mtd%d", > > > + i); > > > + if (err) { > > > + /* We lose the errno information :( */ > > > + break; > > > + } > > > > This is not a good idea, even if it'll currently work. > > > > > @@ -692,6 +698,15 @@ static int __init init_mtd(void) > > > int ret; > > > ret = class_register(&mtd_class); > > > > > > + ret = bdi_init(&mtd_bdi_unmappable); > > > + if (ret) > > > + return ret; > > > + ret = bdi_init(&mtd_bdi_ro_mappable); > > > + if (ret) > > > + return ret; > > > + ret = bdi_init(&mtd_bdi_rw_mappable); > > > + if (ret) > > > + return ret; > > > > Do the bdi_register() here as well. > > -ENOBRAIN > > Initially I wanted to do just than. Then I looked at the block layer > and thought we could create one backing_dev_info per mtd as well. Not > necessarily a bad if I would actually _create_ them and not just reuse > the same ones over and over again. I cooked up that patch myself, here: http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=0661b1ac5d48eb47c8a5948c0554fea25e0895ab Care to give it a quick spin? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/