Date: Tue, 27 Apr 2010 10:25:00 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.cz>
To: Jiri Slaby <jirislaby@gmail.com>, Alan Ott <alan@signal11.us>
Cc: Stephane Chatty <chatty@enac.fr>, Marcel Holtmann <marcel@holtmann.org>,
       simon.windows@gmail.com, linux-input@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Bug in hidraw When a HID Device Contains Multiple
 Reports
In-Reply-To: <4BD69047.3010703@gmail.com>
Message-ID: <alpine.LNX.2.00.1004271024140.7579@pobox.suse.cz>
References: <4BD61506.1030301@signal11.us> <4BD69047.3010703@gmail.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 30

On Tue, 27 Apr 2010, Jiri Slaby wrote:

> On 04/27/2010 12:34 AM, Alan Ott wrote:
> > Make hidraw not stick an extra byte on the beginning of an IN transfer
> > when a HID device contains multiple reports.
> ...
> > I have attached a patch which seems to take care of this problem. Please
> > let me know if I have completely misjudged the situation.
> 
> Nope, your analysis is correct. It was introduced by me in 85cdaf524. I
> apparently forgot to change the hidraw case, so your fix is OK.

Yeah, the analysis is correct, thanks a lot for catching this Alan!

I have put 

	Acked-by: Jiri Slaby <jslaby@suse.cz>

to the patch and applied it.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/