Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168Ab0D0PGV (ORCPT ); Tue, 27 Apr 2010 11:06:21 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:50417 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011Ab0D0PGT (ORCPT ); Tue, 27 Apr 2010 11:06:19 -0400 From: Arnd Bergmann To: =?utf-8?q?J=C3=B6rn_Engel?= Subject: Re: [PATCH 1/7] logfs: push down BKL into ioctl function Date: Tue, 27 Apr 2010 17:05:50 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: John Kacur , lkml , Linus Torvalds , Frederic Weisbecker , Jan Blunck , Thomas Gleixner References: <1272378265-10909-2-git-send-email-arnd@arndb.de> <20100427145804.GA16794@logfs.org> In-Reply-To: <20100427145804.GA16794@logfs.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <201004271705.50499.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX19xA/mURUaah4eHx3S8G8wnj1CUj2q/mEqjQra ZoWp+Yg+xoPEbLs1rdMAByes3kJgQBD+Swkvm446BjtoUREbKQ GqJ1CWCgPTNq2jd3hjMjA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 22 On Tuesday 27 April 2010, Jörn Engel wrote: > On Tue, 27 April 2010 16:24:19 +0200, Arnd Bergmann wrote: > > > > I'm sure that logfs doesn't rely on the BKL, but right now, > > we're just pushing it down. > > So why do you create logfs_unlocked_ioctl in the first place? ;) I don't want to get caught in discussions on whether any of my patches might introduce silent bugs in something I'm not maintaining. Also to put pressure on maintainers by threatening them to make their code ugly. If you just add a patch to convert to ->unlocked_ioctl without the BKL, we can drop this patch ;-) Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/