Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735Ab0D0RNR (ORCPT ); Tue, 27 Apr 2010 13:13:17 -0400 Received: from vms173007pub.verizon.net ([206.46.173.7]:14184 "EHLO vms173007pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754114Ab0D0RNP (ORCPT ); Tue, 27 Apr 2010 13:13:15 -0400 Date: Tue, 27 Apr 2010 13:12:49 -0400 (EDT) From: Len Brown X-X-Sender: lenb@localhost.localdomain To: Thadeu Lima de Souza Cascardo Cc: linux-acpi@vger.kernel.org, rui.zhang@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI: fix fan module removal when ACPI_PROCFS is disabled In-reply-to: <1272385158-4080-1-git-send-email-cascardo@holoscopio.com> Message-id: References: <1272385158-4080-1-git-send-email-cascardo@holoscopio.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 17 > When ACPI_PROCFS is disabled, /proc/acpi/fan/ directory is not created. > So, it should not be removed during the module removal either. Yes, this patch would make the #ifdefs consistent. But it looks like remove_proc_entry() just silently does nothing if the directory is not there, yes? What I'd really like to see is a patch removing fan.c's proc code completely. It was scheduld for removal in July 2008. thanks, Len Brown, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/