Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755407Ab0D0U2N (ORCPT ); Tue, 27 Apr 2010 16:28:13 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:53697 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754682Ab0D0U2L (ORCPT ); Tue, 27 Apr 2010 16:28:11 -0400 Date: Tue, 27 Apr 2010 22:28:08 +0200 From: Sam Ravnborg To: Nicolas Palix Cc: Andrew Morton , Joe Perches , "David S. Miller" , Michal Marek , Julia Lawall , Gilles Muller , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, cocci@diku.dk Subject: Re: [PATCH 1/4] Add targets to use the Coccinelle checker Message-ID: <20100427202808.GA25732@merkur.ravnborg.org> References: <1272316279-12042-1-git-send-email-npalix@diku.dk> <1272316279-12042-2-git-send-email-npalix@diku.dk> <20100427202403.GA25722@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100427202403.GA25722@merkur.ravnborg.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 36 On Tue, Apr 27, 2010 at 10:24:03PM +0200, Sam Ravnborg wrote: > Hej Nicolas. > > On Mon, Apr 26, 2010 at 11:11:16PM +0200, Nicolas Palix wrote: > > Four targets are added. Each one generates a different > > output kind: context, patch, org, report. > > Every SmPL file in 'scripts/smpl' is given to the spatch frontend > > (located in the 'scripts' directory), and applied to the entire > > source tree. > > For outsiders smpl does not rellate to coccinelle. > > I suggest to consistently use the name of the tool in all places. > > So smpl directory to be named coccinelle > SPATCH named coccinelle > spatch.sh named coccinelle.sh > etc. > > This way we use one name for one thing. And not today where you > use three names for the same thing. > The files may be named *.smpl - because their home in > > scripts/coccinelle/ > > will tell what they are used for. Looking again they are named *.cocci. So I confused myself on the smpl thing. The point above consistent naming still holds. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/