Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754288Ab0D1NWl (ORCPT ); Wed, 28 Apr 2010 09:22:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45969 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397Ab0D1NWj (ORCPT ); Wed, 28 Apr 2010 09:22:39 -0400 Message-ID: <4BD806E7.7010806@redhat.com> Date: Wed, 28 Apr 2010 17:59:03 +0800 From: Cong Wang User-Agent: Thunderbird 2.0.0.23 (X11/20091001) MIME-Version: 1.0 To: Dongdong Deng CC: linux-kernel@vger.kernel.org, Matt Mackall , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, Andy Gospodarek , Neil Horman , Jeff Moyer , Stephen Hemminger , bonding-devel@lists.sourceforge.net, Jay Vosburgh , David Miller Subject: Re: [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices References: <20100427075937.4908.18468.sendpatchset@localhost.localdomain> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 19 Dongdong Deng wrote: > > > + if (ops->ndo_netpoll_cleanup) > + ops->ndo_netpoll_cleanup(np->dev); > + np->dev->npinfo = NULL; > > I think it is good to set np->dev->npinfo to NULL even though we have > the netpoll_cleanup opt. > This is redundant, since ->ndo_netpoll_cleanup will set it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/