Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755888Ab0D1Qen (ORCPT ); Wed, 28 Apr 2010 12:34:43 -0400 Received: from www.tglx.de ([62.245.132.106]:35829 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755824Ab0D1Qel (ORCPT ); Wed, 28 Apr 2010 12:34:41 -0400 Date: Wed, 28 Apr 2010 18:34:31 +0200 (CEST) From: Thomas Gleixner To: Xianghua Xiao cc: john stultz , LKML Subject: Re: 2.6.33.3-rt16 Oops caused by umount In-Reply-To: Message-ID: References: <1272399798.2255.2.camel@localhost> <1272400246.2255.5.camel@localhost> <1272434481.1974.101.camel@work-vm> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 50 On Wed, 28 Apr 2010, Xianghua Xiao wrote: > Just tried the patch, still got umount hang, please see below. Can you please apply the patch below and provide the debug output ? Thanks, tglx --- fs/file_table.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) Index: linux-2.6-tip/fs/file_table.c =================================================================== --- linux-2.6-tip.orig/fs/file_table.c +++ linux-2.6-tip/fs/file_table.c @@ -410,7 +410,27 @@ int fs_may_remount_ro(struct super_block list = &sb->s_files; #endif list_for_each_entry(file, list, f_u.fu_list) { - struct inode *inode = file->f_path.dentry->d_inode; + struct inode *inode; + + if (!file->f_path) { + printk(KERN_ERR "file %p fpath == NULL\n", + file); + continue; + } + + if (!file->f_path.dentry) { + printk(KERN_ERR "file %p dentry == NULL\n", + file); + continue; + } + + if (!file->f_path.dentry->d_inode) { + printk(KERN_ERR "file %p d_inode == NULL\n", + file); + continue; + } + + inode = file->f_path.dentry->d_inode; /* File with pending delete? */ if (inode->i_nlink == 0) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/