Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882Ab0D1LKs (ORCPT ); Wed, 28 Apr 2010 07:10:48 -0400 Received: from mail.gmx.net ([213.165.64.20]:46866 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751290Ab0D1LKq (ORCPT ); Wed, 28 Apr 2010 07:10:46 -0400 X-Authenticated: #15668376 X-Provags-ID: V01U2FsdGVkX18ZozY3IxoZi5cn2CrGXIWp3ET2Cz+VD3oxTp/dd3 +7KqgD+7C/q6EX From: Peter Fritzsche To: Arnd Bergmann , Ingo Molnar , Andrew Morton , Heiko Carstens , Mathieu Desnoyers , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Keith M Wesolowski Cc: Peter Fritzsche Subject: [PATCH 2/2] asm-generic: Don't warn that atomic_t is only 24 bit Date: Wed, 28 Apr 2010 13:10:36 +0200 Message-Id: <1272453036-18670-1-git-send-email-peter.fritzsche@gmx.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1272451837-17961-1-git-send-email-peter.fritzsche@gmx.de> References: <1272451837-17961-1-git-send-email-peter.fritzsche@gmx.de> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55000000000000004 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2408 Lines: 68 32-bit Sparc used to only allow usage of 24-bit of it's atomic_t type. This was corrected with linux 2.6.3 when Keith M Wesolowski changed the implementation to use the parisc approach of having an array of spinlocks to protect the atomic_t. These warnings were also removed from the sparc implementation when the new implementation was merged in BKrev:402e4949VThdc6D3iaosSFUgabMfvw, but the warning still remained in some other places without any 24-bit-only atomic_t implementation inside the kernel. We should remove these warnings to allow users to rely on the full 32-bit range of atomic_t. Signed-off-by: Peter Fritzsche --- This should correct the problem mentioned in http://lkml.org/lkml/2010/4/26/33 include/asm-generic/atomic.h | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/asm-generic/atomic.h b/include/asm-generic/atomic.h index c99c64d..345bfda 100644 --- a/include/asm-generic/atomic.h +++ b/include/asm-generic/atomic.h @@ -30,8 +30,7 @@ * atomic_read - read atomic variable * @v: pointer of type atomic_t * - * Atomically reads the value of @v. Note that the guaranteed - * useful range of an atomic_t is only 24 bits. + * Atomically reads the value of @v. */ #define atomic_read(v) ((v)->counter) @@ -40,8 +39,7 @@ * @v: pointer of type atomic_t * @i: required value * - * Atomically sets the value of @v to @i. Note that the guaranteed - * useful range of an atomic_t is only 24 bits. + * Atomically sets the value of @v to @i. */ #define atomic_set(v, i) (((v)->counter) = (i)) @@ -53,7 +51,6 @@ * @v: pointer of type atomic_t * * Atomically adds @i to @v and returns the result - * Note that the guaranteed useful range of an atomic_t is only 24 bits. */ static inline int atomic_add_return(int i, atomic_t *v) { @@ -75,7 +72,6 @@ static inline int atomic_add_return(int i, atomic_t *v) * @v: pointer of type atomic_t * * Atomically subtracts @i from @v and returns the result - * Note that the guaranteed useful range of an atomic_t is only 24 bits. */ static inline int atomic_sub_return(int i, atomic_t *v) { -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/