Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757263Ab0D1WbK (ORCPT ); Wed, 28 Apr 2010 18:31:10 -0400 Received: from mail-px0-f174.google.com ([209.85.212.174]:54699 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754967Ab0D1WbH convert rfc822-to-8bit (ORCPT ); Wed, 28 Apr 2010 18:31:07 -0400 MIME-Version: 1.0 In-Reply-To: <201004282258.51354.rjw@sisk.pl> References: <1272429119-12103-1-git-send-email-arve@android.com> <1272429119-12103-2-git-send-email-arve@android.com> <1272429119-12103-3-git-send-email-arve@android.com> <201004282258.51354.rjw@sisk.pl> Date: Wed, 28 Apr 2010 15:31:03 -0700 Message-ID: Subject: Re: [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Alan Stern , Tejun Heo , Oleg Nesterov , Randy Dunlap , Andrew Morton , Ryusuke Konishi , Jim Collar , Greg Kroah-Hartman , Avi Kivity , Len Brown , Pavel Machek , Magnus Damm , Cornelia Huck , Nigel Cunningham , linux-doc@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 59 2010/4/28 Rafael J. Wysocki : > On Wednesday 28 April 2010, Arve Hj?nnev?g wrote: >> Add a misc device, "suspend_blocker", that allows user-space processes >> to block auto suspend. The device has ioctls to create a suspend_blocker, >> and to block and unblock suspend. To delete the suspend_blocker, close >> the device. >> >> Signed-off-by: Arve Hj?nnev?g > ... >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +enum { >> + ? ? DEBUG_FAILURE ? = BIT(0), >> +}; >> +static int debug_mask = DEBUG_FAILURE; > > What's the exact purpose of this? To show errors returned to user space. I can turn it off by default if you want. > >> +module_param_named(debug_mask, debug_mask, int, S_IRUGO | S_IWUSR | S_IWGRP); >> + >> +static DEFINE_MUTEX(ioctl_lock); >> + >> +struct user_suspend_blocker { >> + ? ? struct suspend_blocker ?blocker; >> + ? ? char ? ? ? ? ? ? ? ? ? ?name[0]; >> +}; > > Why is this not in a header? It's private to this file. > > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > Please read the FAQ at ?http://www.tux.org/lkml/ > -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/