Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757337Ab0D1XEz (ORCPT ); Wed, 28 Apr 2010 19:04:55 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:53829 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755513Ab0D1XEy convert rfc822-to-8bit (ORCPT ); Wed, 28 Apr 2010 19:04:54 -0400 From: "Rafael J. Wysocki" To: Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= Subject: Re: [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space Date: Thu, 29 Apr 2010 01:05:15 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc4-rjw; KDE/4.3.5; x86_64; ; ) Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Alan Stern , Tejun Heo , Oleg Nesterov , Randy Dunlap , Andrew Morton , Ryusuke Konishi , Jim Collar , "Greg Kroah-Hartman" , Avi Kivity , Len Brown , Pavel Machek , Magnus Damm , Cornelia Huck , Nigel Cunningham , linux-doc@vger.kernel.org References: <1272429119-12103-1-git-send-email-arve@android.com> <201004282258.51354.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-Id: <201004290105.15707.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 39 On Thursday 29 April 2010, Arve Hj?nnev?g wrote: > 2010/4/28 Rafael J. Wysocki : > > On Wednesday 28 April 2010, Arve Hj?nnev?g wrote: > >> Add a misc device, "suspend_blocker", that allows user-space processes > >> to block auto suspend. The device has ioctls to create a suspend_blocker, > >> and to block and unblock suspend. To delete the suspend_blocker, close > >> the device. > >> > >> Signed-off-by: Arve Hj?nnev?g > > ... > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +enum { > >> + DEBUG_FAILURE = BIT(0), > >> +}; > >> +static int debug_mask = DEBUG_FAILURE; > > > > What's the exact purpose of this? > > To show errors returned to user space. I can turn it off by default if you want. Not necessarily, but why is it a mask? It looks like a 0/1 thing would be sufficient. BTW, I'd put parens around (debug_mask & DEBUG_FAILURE) for clarity. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/