Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932416Ab0D1XKL (ORCPT ); Wed, 28 Apr 2010 19:10:11 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:17494 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757246Ab0D1XKI convert rfc822-to-8bit (ORCPT ); Wed, 28 Apr 2010 19:10:08 -0400 Subject: Re: Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Andreas Dilger In-Reply-To: <20100422132929.GA27380@ca-server1.us.oracle.com> Date: Wed, 28 Apr 2010 17:08:54 -0600 Cc: Chris Mason , Al Viro , Andrew Morton , "Theodore Ts'o" , mfasheh@suse.com, Joel Becker , Matthew Wilcox , linux-btrfs@vger.kernel.org, "linux-kernel@vger.kernel.org Mailinglist" , linux-fsdevel@vger.kernel.org, linux-ext4 development , ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, ngupta@vflare.org, Jeremy Fitzhardinge , JBeulich@novell.com, kurt.hackel@oracle.com, Nick Piggin , dave.mccracken@oracle.com, Rik van Riel Content-Transfer-Encoding: 8BIT Message-Id: <8EEE8A6D-343A-4514-BFC8-1EFEDE180B70@sun.com> References: <20100422132929.GA27380@ca-server1.us.oracle.com> To: Dan Magenheimer X-Mailer: Apple Mail (2.1078) X-Auth-Type: Internal IP X-Source-IP: rcsinet13.oracle.com [148.87.113.125] X-CT-RefId: str=0001.0A090207.4BD8C035.00B9,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 46 On 2010-04-22, at 07:29, Dan Magenheimer wrote: > Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook > > Filesystems must explicitly enable cleancache. For ext4, > all other cleancache hooks are in the VFS layer. > > Signed-off-by: Dan Magenheimer Given the minimal changes being done to ext3/ext4, I don't have any objection to this. Being able to hook ext4 into SSDs for hierarchical caching is something that will become increasingly important for huge ext4 filesystems. Acked-by: Andreas Dilger > Diffstat: > super.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-2.6.34-rc5/fs/ext4/super.c 2010-04-19 17:29:56.000000000 -0600 > +++ linux-2.6.34-rc5-cleancache/fs/ext4/super.c 2010-04-21 10:13:00.000000000 -0600 > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > #include > > #include "ext4.h" > @@ -1784,6 +1785,7 @@ static int ext4_setup_super(struct super > EXT4_INODES_PER_GROUP(sb), > sbi->s_mount_opt); > > + sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE); > return res; > } Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/