Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758499Ab0D3Rca (ORCPT ); Fri, 30 Apr 2010 13:32:30 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:34090 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933330Ab0D3RcD (ORCPT ); Fri, 30 Apr 2010 13:32:03 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=uL0LHwP9FEfMYJeQnHvK1v4kX/u2Hfu7SJRF9s1GgeXn1dh7RVAe9DkObutV/3SDfT 2WyAkM/QQF/yJa8w9x890PZw3o9c9lvtghm1QPykv/1idEz4sKhJNe1Md4Ef/SImvgkL +E14UeOwCve1eHD582jnwnsKRzEANO3PA6ol8= Date: Thu, 29 Apr 2010 11:29:57 +0200 From: Dan Carpenter To: Zhu Yi Cc: "Ortiz, Samuel" , Intel Linux Wireless , "John W. Linville" , Andrew Morton , Alexey Dobriyan , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [patch] iwl: cleanup: remove unneeded error handling Message-ID: <20100429092956.GH29093@bicker> Mail-Followup-To: Dan Carpenter , Zhu Yi , "Ortiz, Samuel" , Intel Linux Wireless , "John W. Linville" , Andrew Morton , Alexey Dobriyan , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" References: <20100428090115.GF29093@bicker> <1272507134.14773.4339.camel@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1272507134.14773.4339.camel@debian> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 32 On Thu, Apr 29, 2010 at 10:12:14AM +0800, Zhu Yi wrote: > > Thanks. But looks like you missed the one in if_sdio_debugfs_init(). > Yup. > I don't think we even need to check -ENODEV ourselves because if > DEBUG_FS is not compiled in, all the debugfs utility functions will > become no-op. > Good point. > Signed-off-by: Dan Carpenter Probably this could get changed to just "Reported-by" but I'm happy to take credit for other peoples work. :) > Signed-off-by: Zhu Yi > Acked-by: Dan Carpenter regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/