Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932963Ab0D3RoN (ORCPT ); Fri, 30 Apr 2010 13:44:13 -0400 Received: from mail-qy0-f183.google.com ([209.85.221.183]:36704 "EHLO mail-qy0-f183.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933483Ab0D3Rnu convert rfc822-to-8bit (ORCPT ); Fri, 30 Apr 2010 13:43:50 -0400 MIME-Version: 1.0 In-Reply-To: References: <4BDAF376.4030005@in.ibm.com> <4BDB12FB.5060806@in.ibm.com> From: Grant Likely Date: Fri, 30 Apr 2010 11:43:22 -0600 X-Google-Sender-Auth: f88ab60bf9b0441a Message-ID: Subject: Re: -next Apr 30: OOPS during eHEA driver initialization To: Sachin Sant Cc: "Linux/PPC Development" , "linux-next@vger.kernel.org" , Benjamin Herrenschmidt , Greg Kroah-Hartman , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 45 On Fri, Apr 30, 2010 at 11:35 AM, Grant Likely wrote: > On Fri, Apr 30, 2010 at 11:27 AM, Sachin Sant wrote: >> Sachin Sant wrote: >>> >>> With today's next eHEA drivers fails to initialize. >> >> If i revert the following patch eHEA network interface is initialized >> properly. >> >> commit cebfe0b6709abdab997c1a00499d67efa32ee1f0 >> drivercore: Add of_match_table to the common device drivers > > That is an easy one to fix. ?I'll get it updated today and send you the result. Let me know if this patch fixes it: Cheers, g. diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index ce957a4..693b0e6 100644 --- a/arch/powerpc/kernel/ibmebus.c +++ b/arch/powerpc/kernel/ibmebus.c @@ -201,6 +201,9 @@ static int ibmebus_create_devices(const struct of_device_id *matches) int ibmebus_register_driver(struct of_platform_driver *drv) { + if (!drv->driver.of_match_table) + drv->driver.of_match_table = drv->match_table; + /* If the driver uses devices that ibmebus doesn't know, add them */ ibmebus_create_devices(drv->driver.of_match_table); -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/