Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934063Ab0D3SxC (ORCPT ); Fri, 30 Apr 2010 14:53:02 -0400 Received: from fallback.mail.elte.hu ([157.181.151.13]:46108 "EHLO fallback.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758919Ab0D3Sw1 (ORCPT ); Fri, 30 Apr 2010 14:52:27 -0400 Date: Fri, 30 Apr 2010 10:37:20 +0200 From: Ingo Molnar To: Jiri Kosina Cc: Tejun Heo , lkml , Paul Mackerras Subject: Re: [PATCH] trivial: use (C) instead of \251 Message-ID: <20100430083720.GA3318@elte.hu> References: <4BD80037.9060704@kernel.org> <20100430075510.GA21105@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2173 Lines: 61 * Jiri Kosina wrote: > On Fri, 30 Apr 2010, Ingo Molnar wrote: > > > > > The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and > > > > causes annoying problems with some editors and tools. Use (C) > > > > instead. > > > > > > > > Signed-off-by: Tejun Heo > > > > Cc: Paul Mackerras > > > > --- > > > > I'm not really sure this would survive transport over mail in > > > > appliable form, attaching the patch too just in case. > > > > > > It didn't survive :) But it was easy enough to fix by hand. Applied, > > > thanks Tejun. > > > > NAK. > > > > A similar patch was sent a few weeks ago, it was objected to and rejected - > > the copyright character was used for legal reasons. > > Well, Paul himself stated that according to their lawyer department, > "Copyright" (which is there) is enough. So it made sense to remove invalid > (at least in some sense) character. > > Also zillion of other files copyrighted by Paul contain "Copyright (C)". > > If we really want this character there then, why not rather in UTF-8, so > that it works flawlessly? It might be fine but i havent seen Paul reply to this thread - and this is my point: _you_ should have waited for an ack from Paul (who is co-maintaining that file) before applying it. The commit doesnt have it: commit 62006c58a9a2d8b72b5b65301965bc444d43e22c Author: Tejun Heo Date: Wed Apr 28 11:30:31 2010 +0200 trivial: use (C) instead of \251 The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and causes annoying problems with some editors and tools. Use (C) instead. Signed-off-by: Tejun Heo Cc: Paul Mackerras Signed-off-by: Jiri Kosina We dont just go and change people's copyright notices, no matter how trivial it may seem ... Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/