Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756343Ab0FANfL (ORCPT ); Tue, 1 Jun 2010 09:35:11 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:28905 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755885Ab0FANfJ (ORCPT ); Tue, 1 Jun 2010 09:35:09 -0400 Date: Tue, 1 Jun 2010 09:33:41 -0400 From: Chris Mason To: James Bottomley Cc: Christof Schmitt , Boaz Harrosh , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: Wrong DIF guard tag on ext2 write Message-ID: <20100601133341.GK8980@think> Mail-Followup-To: Chris Mason , James Bottomley , Christof Schmitt , Boaz Harrosh , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20100531112817.GA16260@schmichrtp.mainz.de.ibm.com> <1275318102.2823.47.camel@mulgrave.site> <4C03D5FD.3000202@panasas.com> <20100601103041.GA15922@schmichrtp.mainz.de.ibm.com> <1275398876.21962.6.camel@mulgrave.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1275398876.21962.6.camel@mulgrave.site> User-Agent: Mutt/1.5.20 (2009-06-14) X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090205.4C050C86.009C:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 22 On Tue, Jun 01, 2010 at 01:27:56PM +0000, James Bottomley wrote: > On Tue, 2010-06-01 at 12:30 +0200, Christof Schmitt wrote: > > What is the best strategy to continue with the invalid guard tags on > > write requests? Should this be fixed in the filesystems? > > For write requests, as long as the page dirty bit is still set, it's > safe to drop the request, since it's already going to be repeated. What > we probably want is an error code we can return that the layer that sees > both the request and the page flags can make the call. I'm afraid this isn't entirely true. The FS tends to do this: change the page <---------> truck sized race right here where the page is clean mark the page dirty -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/