Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932191Ab0FAU5P (ORCPT ); Tue, 1 Jun 2010 16:57:15 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:40420 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155Ab0FAU5L convert rfc822-to-8bit (ORCPT ); Tue, 1 Jun 2010 16:57:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=cR38batlWGHAlII2CuUfZvAkbSnXho+c8SDNW2/MaIq7TnfqQwOi5YXpClnUrhzRgO ewFyUXn7Czmy9ilI6zOHX7g8QUVS5ADiOIHqmSOwgRNvioZaUufH4amRegL683a+Nz5M BbBqpLJLCaRgy/pUMTAw3E5k4dPPqlzabdEGM= MIME-Version: 1.0 In-Reply-To: References: <20100601185937.5188.77506.stgit@warthog.procyon.org.uk> From: Mike Frysinger Date: Tue, 1 Jun 2010 16:52:02 -0400 Message-ID: Subject: Re: [Uclinux-dist-devel] [PATCH] NOMMU: Add '[stack]' label to /proc/pid/maps output To: Linus Torvalds Cc: David Howells , uclinux-dist-devel@blackfin.uclinux.org, akpm@linux-foundation.org, uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1049 Lines: 26 On Tue, Jun 1, 2010 at 15:07, Linus Torvalds wrote: > On Tue, 1 Jun 2010, David Howells wrote: >> Add support to the NOMMU /proc/pid/maps file to show which mapping is the stack >> of the original thread after execve.  This is largely based on the MMU code. > > Umm? The MMU code that we _reverted_? to be fair, this patch was written a few kernel revisions ago and you're referring to commit merged a few weeks ago ... > It turns out to be totally useless, since people put stacks in various > different places, and the values the kernel does see end up not even being > the "real" stack top. > > See commit 34441427aab4bdb3069a4ffcda69a99357abcb2e. > > Just don't do it. but i dont think we're talking the same thing. that commit refers to [threadstack]. afaict, [stack] is still in there. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/