Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757477Ab0FBCvM (ORCPT ); Tue, 1 Jun 2010 22:51:12 -0400 Received: from mail-pz0-f185.google.com ([209.85.222.185]:52813 "EHLO mail-pz0-f185.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755842Ab0FBCvK (ORCPT ); Tue, 1 Jun 2010 22:51:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=QPmvPgZq1ZjiA0tG9yq0ZTNDOjb6RI6wgliLiA7LsKVtXp78twyk8tdecmMcsHUEQ6 ewevYZPFacBsyyUI6P2PlzfEo/uFgE6SiW5JB4OzurQifcGC0nIfVx/j2cg1NYo3OIUf nB4WW6+4fe9UWv5DoAyJa9/jyByh0l7foG7F8= Date: Tue, 1 Jun 2010 19:51:23 -0700 From: mark gross <640e9920@gmail.com> To: Florian Mickler Cc: markgross@thegnar.org, 640e9920@gmail.com, "Rafael J. Wysocki" , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Alan Stern , Peter Zijlstra , Linux PM , Brian Swetland , Alan Cox , Matthew Garrett , Thomas Gleixner , LKML , Ingo Molnar Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8) Message-ID: <20100602025123.GB5764@gvim.org> Reply-To: markgross@thegnar.org References: <201005312338.55109.rjw@sisk.pl> <20100531232617.GF31155@gvim.org> <20100601090737.4bc243d9@schatten.dmk.lab> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100601090737.4bc243d9@schatten.dmk.lab> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2195 Lines: 52 On Tue, Jun 01, 2010 at 09:07:37AM +0200, Florian Mickler wrote: > On Mon, 31 May 2010 16:26:17 -0700 > mark gross <640e9920@gmail.com> wrote: > > > On Mon, May 31, 2010 at 11:38:55PM +0200, Rafael J. Wysocki wrote: > > > On Monday 31 May 2010, Arve Hj?nnev?g wrote: > > > > 2010/5/29 Alan Stern : > > > > > On Sat, 29 May 2010, Arve Hj?nnev?g wrote: > > > > > > > > > >> > In place of in-kernel suspend blockers, there will be a new type of QoS > > > > >> > constraint -- call it QOS_EVENTUALLY. It's a very weak constraint, > > > > >> > compatible with all cpuidle modes in which runnable threads are allowed > > > > >> > to run (which is all of them), but not compatible with suspend. > > > > >> > > > > > >> This sound just like another API rename. It will work, but given that > > > > >> suspend blockers was the name least objectionable last time around, > > > > >> I'm not sure what this would solve. > > > > > > > > > > It's not just a rename. By changing this into a QoS constraint, we > > > > > make it more generally useful. Instead of standing on its own, it > > > > > becomes part of the PM-QOS framework. > > > > > > > > > > > > > We cannot use the existing pm-qos framework. It is not safe to call > > > > from atomic context. > > > > > > We've just merged a patch that fixed that if I'm not mistaken. Mark, did your > > > PM QoS update fix that? > > > > > > > I'm pretty sure it can be called in atomic context, and if its not I'm > > sure we can fix that. It can be called in atomic context. I don't > > think it was ever a problem to call it in atomic context. The problem it > > had was that crappy list of string compares. Thats been fixed. > > > > --mgross > > > > Well, the register call uses kzalloc. Apart from that I > think we're good. registering shouldn't need to be called in atomic context. Its the update_request that needs to be callible form atomic context. --mgross -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/