Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004Ab0FBGHI (ORCPT ); Wed, 2 Jun 2010 02:07:08 -0400 Received: from ringil.hengli.com.au ([216.59.3.182]:36822 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751662Ab0FBGHF (ORCPT ); Wed, 2 Jun 2010 02:07:05 -0400 Date: Wed, 2 Jun 2010 16:07:02 +1000 From: Herbert Xu To: Mikulas Patocka Cc: device-mapper development , linux-kernel@vger.kernel.org, agk@redhat.com, ak@linux.intel.com Subject: Re: [dm-devel] [PATCH] DM-CRYPT: Scale to multiple CPUs Message-ID: <20100602060702.GA6319@gondor.apana.org.au> References: <20100531160425.GA20344@basil.fritz.box> <20100601043901.GA25693@gondor.apana.org.au> <20100602051403.GA5784@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 33 On Wed, Jun 02, 2010 at 01:25:11AM -0400, Mikulas Patocka wrote: > > Are you sure that you know what you're talking about? pcrypt_alloc > contains this: > switch (algt->type & algt->mask & CRYPTO_ALG_TYPE_MASK) { > case CRYPTO_ALG_TYPE_AEAD: > return pcrypt_alloc_aead(tb); > } > > return ERR_PTR(-EINVAL); > --- so for anything other byt AEAD it returns -EINVAL. So someone needs to write the ablkcipher plugins for pcrypt. This is the whole point of pcrypt, to implement parallelisation exactly once, in the crypto layer. > For what? For avoiding cache bounces? But the encrypting is > order-of-magnitude slower than memory speed. Have you benchmarked the Nehalem AES performance lately? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/