Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757739Ab0FBKAv (ORCPT ); Wed, 2 Jun 2010 06:00:51 -0400 Received: from mail-ew0-f223.google.com ([209.85.219.223]:45933 "EHLO mail-ew0-f223.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754931Ab0FBKAt convert rfc822-to-8bit (ORCPT ); Wed, 2 Jun 2010 06:00:49 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; b=F1Irg6rFLZR29oCPtoquhbIAt6p9/ZFhe/XWYzMevfCjcrS/QCxNoHR4f+8pskK3B3 Kn2NnnxrmrCqzXCrzfOmHam2vtFg9AFQYKTh32FeN50sEtZRW2aUk3QFByr0DGT+I6Ws gr4GGLm2X9S5qYjKFvoLCJH1GE6UMShWb4934= Date: Wed, 02 Jun 2010 12:00:47 +0200 Message-ID: <874ohl21ps.wl%vmayatsk@redhat.com> From: Vitaly Mayatskikh To: Pekka Enberg Cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Vivek Goyal , Randy Dunlap Subject: Re: [PATCH 2/5] x86: Split __show_regs() In-Reply-To: References: <1275464359-1566-1-git-send-email-v.mayatskih@gmail.com> <1275464359-1566-3-git-send-email-v.mayatskih@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/23.2 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 30 At Wed, 2 Jun 2010 12:50:03 +0300, Pekka Enberg wrote: > > On Wed, Jun 2, 2010 at 10:39 AM, Vitaly Mayatskikh > wrote: > > __show_regs dumps content of pt_regs and does other things beside > > it. This patch moves pt_regs dumping part into separate function: > > __show_main_regs. > > > > Signed-off-by: Vitaly Mayatskikh > > [snip] > > > +void __show_regs(struct pt_regs *regs, int all) > > +{ > > +       unsigned long cr0 = 0L, cr2 = 0L, cr3 = 0L, cr4 = 0L; > > +       unsigned long d0, d1, d2, d3, d6, d7; > > + > > + > > Nitpick: extra newline here. Thanks for catching! -- wbr, Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/