Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758251Ab0FBNyK (ORCPT ); Wed, 2 Jun 2010 09:54:10 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:43687 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754912Ab0FBNyE convert rfc822-to-8bit (ORCPT ); Wed, 2 Jun 2010 09:54:04 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: David Rientjes Subject: Re: [RFC] oom-kill: give the dying task a higher priority Cc: kosaki.motohiro@jp.fujitsu.com, "Luis Claudio R. Goncalves" , KAMEZAWA Hiroyuki , Minchan Kim , balbir@linux.vnet.ibm.com, Oleg Nesterov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Gleixner , Peter Zijlstra , Mel Gorman , williams@redhat.com In-Reply-To: References: <20100601173535.GD23428@uudg.org> Message-Id: <20100602220429.F51E.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Becky! ver. 2.50.07 [ja] Date: Wed, 2 Jun 2010 22:54:01 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 26 > > @@ -291,9 +309,10 @@ static struct task_struct *select_bad_process(unsigned long *ppoints, > > * Otherwise we could get an easy OOM deadlock. > > */ > > if (p->flags & PF_EXITING) { > > - if (p != current) > > + if (p != current) { > > + boost_dying_task_prio(p, mem); > > return ERR_PTR(-1UL); > > - > > + } > > chosen = p; > > *ppoints = ULONG_MAX; > > } > > This has the potential to actually make it harder to free memory if p is > waiting to acquire a writelock on mm->mmap_sem in the exit path while the > thread holding mm->mmap_sem is trying to run. if p is waiting, changing prio have no effect. It continue tol wait to release mmap_sem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/