Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932846Ab0FBRC5 (ORCPT ); Wed, 2 Jun 2010 13:02:57 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:44604 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932650Ab0FBRCz (ORCPT ); Wed, 2 Jun 2010 13:02:55 -0400 Date: Wed, 2 Jun 2010 09:53:02 -0700 From: Brandon Philips To: Rusty Russell Cc: Linus Torvalds , Andrew Morton , "Rafael J. Wysocki" , LKML , Jon Masters , Tejun Heo , Masami Hiramatsu , Kay Sievers Subject: Re: [PATCH 2/2] module: fix bne2 "gave up waiting for init of module libcrc32c" Message-ID: <20100602165302.GI10332@jenkins.ifup.org> References: <201005252300.07739.rjw@sisk.pl> <201006021523.00357.rusty@rustcorp.com.au> <201006022336.53024.rusty@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006022336.53024.rusty@rustcorp.com.au> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 30 On 23:36 Wed 02 Jun 2010, Rusty Russell wrote: > On Wed, 2 Jun 2010 04:51:46 pm Linus Torvalds wrote: > > On Wed, 2 Jun 2010, Rusty Russell wrote: > > > > > > Moved all the sysfs-exposing stuff to the end just after we put in the > > > list (and thus to after the find check). > > > > Yeah, makes more sense that way. No reason to expose anything to sysfs > > early. And splitting it into two patches makes it easier to follow than > > the patch I posted. Ack. > > Found another locking issue: the code which verifies we don't export over > an existing symbol needs to be atomic wrt. adding us to the list. > ... > are available in the git repository at: > > ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6 modules I tested this on the machine with the bnx2/libcrc32c issue and it works. Feel free to add Tested-by: Brandon Philips Thanks, Brandon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/