Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933470Ab0FCA5J (ORCPT ); Wed, 2 Jun 2010 20:57:09 -0400 Received: from mail.atheros.com ([12.36.123.2]:62798 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932835Ab0FCA5H (ORCPT ); Wed, 2 Jun 2010 20:57:07 -0400 From: Sujith MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <19462.65068.93701.741079@gargle.gargle.HOWL> Date: Thu, 3 Jun 2010 06:28:20 +0530 To: "Luis R. Rodriguez" CC: Marcel Holtmann , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH 1/8] ath9k: Determine Firmware on probe In-Reply-To: References: <19462.12578.143627.398866@gargle.gargle.HOWL> X-Mailer: VM 8.1.0 under 23.2.1 (x86_64-unknown-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 31 Luis R. Rodriguez wrote: > I had done some something similar for ar9170 a while back [1] when > adding AVM FRITZ support to ar9170 and then got complaints from Marcel > on this approach since it requires synching the PCI device IDs in two > places. I frankly don't care how we do this but we should try to at > least stick to one way of doing this. > > [1] http://osdir.com/ml/linux-wireless/2009-05/msg01219.html I did look at using the device_id table (using USB_DEVICE_VER), but our case is like this: * for prodId, version 2.2 load foo_1_1.fw * for prodId, version everything else, load foo.fw This requires a bit of handling in the driver, hence this patch. But thinking about it, will this work ? USB_DEVICE_VER(vend, 0x7010, 2, 2); [set .driver_info to "foo_1_1.fw] USB_DEVICE(vend, 0x7010); [set .driver_info to "foo.fw"] That is, will the second registration be the fallback case in case bcdLo and bcdHi are _anything_ other than 2.2 ? Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/