Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932973Ab0FCBOU (ORCPT ); Wed, 2 Jun 2010 21:14:20 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:35635 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757816Ab0FCBOT (ORCPT ); Wed, 2 Jun 2010 21:14:19 -0400 Message-ID: <4C07017A.50007@oracle.com> Date: Wed, 02 Jun 2010 18:12:26 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Ben Dooks CC: Nobin Mathew , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org Subject: Re: [TEMP PATCH v2] Re: make ARM=arm menuconfig problem in mainline References:

<20100602085748.6771e025.randy.dunlap@oracle.com> <4C068BAA.4030004@oracle.com> <20100603002526.GV4720@trinity.fluff.org> In-Reply-To: <20100603002526.GV4720@trinity.fluff.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090204.4C0701DA.016B:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3323 Lines: 99 On 06/02/10 17:25, Ben Dooks wrote: > On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote: >> On 06/02/10 09:08, Nobin Mathew wrote: >>> >>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap wrote: >>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote: >>>> >>>>> adding linux-arm-kernel@lists.infradead.org >>>>> >>>>> Hi, >>>>> >>>>> The following entry creates problem in ARM System type menu. I am >>>>> using a Fedora 12 system. >>>> >>>> What kind of problem does it create? >>>> It seems to work for me (on f11, not f12). >>>> Does it have something to do with F12 specifically? >>>> >>>> >>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, >>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it. >>>> >>>> Describe the problem, please. >> >> [please don't top-post] > > > I can think of several solutions, the first being to remove the S3C prefix > friom all these. > > S3C24XX is not acceptable, there's S3C series that are either too old to > be bothered with, or don't fit under this architecture. and not in the current kernel tree? I did not find any others in the current tree.... > how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450 OK, that works. For kbuild/kconfig people: run: make ARCH=arm O=test menuconfig and then select System Type & ARM system type. The kconfig "choice" menu at this point looks empty. It seems to be just a text windowing/display problem. Pressing the down/up arrow keys will display the choices, although not where they should be displayed in the rectangle, and they can be selected there. >>> Sorry if attachments are not allowed, when I go to select ARM system >>> type(OMAP, Davinci etc), I am not seeing any entries there in the pop >>> up window. When I remove bool "Samsung S3C2410, S3C2412, S3C2413, >>> S3C2416, S3C2440, >>>>> S3C2442, S3C2443, S3C2450" it is working fine. I feel it is something to do with length of that string. >>> >>> Thanks >>> Nobin >> >> >> OK, I see that now. Well, it is some kind of problem. >> Adding cc to linux-kbuild mailing list. >> >> >> The patch below fixes the problem temporarily, but the bool string length does >> seem to be a problem. >> >> Thanks for your report. --- From: Randy Dunlap "bool " causes kconfig choices not to be displayed correctly, so temporarily change it to a shorter string until a real fix is found. Signed-off-by: Randy Dunlap Reported-by: Nobin Mathew Cc: Ben Dooks --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20100602.orig/arch/arm/Kconfig +++ linux-next-20100602/arch/arm/Kconfig @@ -629,7 +629,7 @@ config ARCH_SA1100 Support for StrongARM 11x0 based boards. config ARCH_S3C2410 - bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450" + bool "Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450" select GENERIC_GPIO select ARCH_HAS_CPUFREQ select HAVE_CLK -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/