Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932803Ab0FCGXN (ORCPT ); Thu, 3 Jun 2010 02:23:13 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:46365 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932340Ab0FCGXJ (ORCPT ); Thu, 3 Jun 2010 02:23:09 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: "Luis Claudio R. Goncalves" , LKML , linux-mm , Oleg Nesterov , David Rientjes , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin Subject: [PATCH 06/12] oom: remove warning for in mm-less task __oom_kill_process() Cc: kosaki.motohiro@jp.fujitsu.com In-Reply-To: <20100603135106.7247.A69D9226@jp.fujitsu.com> References: <20100603135106.7247.A69D9226@jp.fujitsu.com> Message-Id: <20100603145330.7259.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 3 Jun 2010 15:23:03 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 38 If the race of mm detach in task exiting vs oom is happen, find_lock_task_mm() can be return NULL. So, the warning is pointless. Signed-off-by: KOSAKI Motohiro --- mm/oom_kill.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 618cf44..d4484c5 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -402,12 +402,8 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem, return 1; p = find_lock_task_mm(p); - if (!p) { - WARN_ON(1); - printk(KERN_WARNING "tried to kill an mm-less task %d (%s)!\n", - task_pid_nr(p), p->comm); + if (!p) return 1; - } if (verbose) printk(KERN_ERR "Killed process %d (%s) " -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/