Date: Thu, 3 Jun 2010 07:27:31 -0700
From: Greg KH <gregkh@suse.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org, Johan Hovold <jhovold@gmail.com>,
       Alan Cox <alan@linux.intel.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes
Message-ID: <20100603142731.GA17732@suse.de>
References: <1275566102-5613-1-git-send-email-daniel@caiaq.de>
 <20100603115727.GY2695@buzzloop.caiaq.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100603115727.GY2695@buzzloop.caiaq.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1375
Lines: 33

On Thu, Jun 03, 2010 at 01:57:27PM +0200, Daniel Mack wrote:
> On Thu, Jun 03, 2010 at 01:55:02PM +0200, Daniel Mack wrote:
> > Call set_mctrl() and clear_mctrl() according to the flow control mode
> > selected. This makes serial communication for FT232 connected devices
> > work when CRTSCTS is not set.
> > 
> > This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
> > opened non blocking we still need to raise the carrier"). This patch
> > calls the low-level driver's dtr_rts() function which consequently sets
> > TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without CRTSCTS in
> > cflags, however, does not reset these bits, and so data is not actually
> > sent out on the serial wire.
> > 
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Johan Hovold <jhovold@gmail.com>
> > Cc: Alan Cox <alan@linux.intel.com>
> > Cc: linux-usb@vger.kernel.org
> 
> Oops. I forgot to Cc: stable@kernel.org.
> This is in fact broken since 2.6.31-something.

Thanks for letting me know, I'll add that marking to the patch when I
queue it up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/