Date: Thu, 3 Jun 2010 10:28:17 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Stephen Hemminger <shemminger@vyatta.com>
cc: Andrew Morton <akpm@linux-foundation.org>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0
In-Reply-To: <20100603101501.5e5d7148@nehalam>
Message-ID: <alpine.LFD.2.00.1006031013060.8175@i5.linux-foundation.org>
References: <20100603101501.5e5d7148@nehalam>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1483
Lines: 34


On Thu, 3 Jun 2010, Stephen Hemminger wrote:
> 
> The driver is a complex mess of spaghetti state. Does one of the original
> authors have more background to fix this?

Doubtful. There are no "original authors" left really. Yes, I technically 
wrote the original driver, but it has gotten seriously rewritten a couple 
of times - sadly always just expanding on the cruftyness.

I do wonder a bit why you even care. You can't even buy non-USB floppy 
drives any more (and even the USB ones are really really hard to find), 
and judging by my experiences, they don't last long enough for there to be 
much of a legacy base.

But please post the oops. I don't think it should ever be valid to oops 
even if it gets confused about first_read_date or last_checked. Some 
hacking around for them being "in the future" would be trivial enough.

But most of them shouldn't matter. The whole 'first_read_date', for 
example, is purely used for some randomness - it tries to use the 
'revolutions per second' to decide when to stop the drive, but that's just 
some voodoo programming and has no real meaning, afaik.

The oops would be interesting just to see _which_ case it is that we care 
about the time so much (clearly _too_ much).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/