Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756235Ab0FCTvz (ORCPT ); Thu, 3 Jun 2010 15:51:55 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:36073 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755354Ab0FCTvy (ORCPT ); Thu, 3 Jun 2010 15:51:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=hP/NMGvOUQ10dsLI64eB1QmicTyX/rwgxDFv7zpb2xekUMDBLiuD3JL3qsujvvAm82 Kcx2xnymCPS73K03zwDLBSgLpVGxhghdnDL4HJ9T/AQO5ezW4Z1eo+0bllQlidRUya2E nMcOr1YuWZqLS7pj319Bb0s9UYjNpPAnFkBLo= Date: Thu, 3 Jun 2010 21:52:00 +0200 From: Frederic Weisbecker To: Oleg Nesterov Cc: Andrew Morton , Arjan van de Ven , Ingo Molnar , Roland McGrath , Vegard Nossum , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86: make save_stack_address() !CONFIG_FRAME_POINTER friendly Message-ID: <20100603195157.GC5234@nowhere> References: <20100603193239.GA31530@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100603193239.GA31530@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 22 On Thu, Jun 03, 2010 at 09:32:39PM +0200, Oleg Nesterov wrote: > If CONFIG_FRAME_POINTER=n, print_context_stack() shouldn't neglect the > non-reliable addresses on stack, this is all we have if dump_trace(bp) > is called with the wrong or zero bp. > > For example, /proc/pid/stack doesn't work if CONFIG_FRAME_POINTER=n. > > This patch obviously has no effect if CONFIG_FRAME_POINTER=y, otherwise > it reverts 1650743c "x86: don't save unreliable stack trace entries". > > Also, remove the unnecessary type-cast. > > Signed-off-by: Oleg Nesterov Acked-by: Frederic Weisbecker -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/