Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755580Ab0FCVjv (ORCPT ); Thu, 3 Jun 2010 17:39:51 -0400 Received: from mail.skyhub.de ([78.46.96.112]:36369 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817Ab0FCVju (ORCPT ); Thu, 3 Jun 2010 17:39:50 -0400 Date: Thu, 3 Jun 2010 23:39:43 +0200 From: Borislav Petkov To: Arnaldo Carvalho de Melo Cc: Borislav Petkov , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Steven Rostedt , Lin Ming , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf: Add persistent events Message-ID: <20100603213943.GA25436@liondog.tnic> Mail-Followup-To: Borislav Petkov , Arnaldo Carvalho de Melo , Borislav Petkov , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Steven Rostedt , Lin Ming , linux-kernel@vger.kernel.org References: <20100523185411.GA5608@liondog.tnic> <1274642601.1674.1755.camel@laptop> <20100525073246.GA6085@liondog.tnic> <1274799588.5882.1572.camel@twins> <20100528143311.GB9710@elte.hu> <1275059860.27810.9635.camel@twins> <20100528155719.GA10141@kryptos.osrc.amd.com> <1275070030.1645.362.camel@laptop> <20100603134301.GA30880@kryptos.osrc.amd.com> <20100603173242.GD29202@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20100603173242.GD29202@ghostprotocols.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2279 Lines: 55 From: Arnaldo Carvalho de Melo Date: Thu, Jun 03, 2010 at 02:32:42PM -0300 > Em Thu, Jun 03, 2010 at 03:43:01PM +0200, Borislav Petkov escreveu: > > From: Peter Zijlstra > > Date: Fri, May 28, 2010 at 08:07:10PM +0200 > > > to allocate and attach a buffer to your event (do so for each cpu's MCE > > > event). > > > > > > After that we still need a way to expose all that to userspace, but at > > > least the events will be complete and able to record bits ;-) > > > > Yep, so far so good, the kernel side is almost done - this was the > > easy part :). So recently I started looking into how the userspace > > part could be done most efficiently so that, initially, the RAS daemon > > doesn't suck in all of tools/perf when building and depend unnecessary > > on libelf etc, and, at the same time, doesn't duplicate functionality > > like util/debugfs, get_debugfs_mntpt(), parse_events() maybe later etc. > > > > So, the best way to do this, IMHO, is if I start carving out common and > > generic functionality into tools/lib/ or tools/util/ or similar so that > > perf and ras can share those. And maybe later even other tools. This > > could be where we host all the kernel headers stuff which are good for > > userspace, i.e. those which are in tools/perf/util/include/linux/ > > > > Opinions, comments? > > Right, that has to be done, I have sample code I want to put in samples/ > to show how to use the symbol libraries in tools/perf/util/, will take a > stab at moving things for tools/lib/. Cool. > We'll need a top level Makefile, I guess, so that when asking to build > tools/perf, it notices that it has to build tools/lib/, etc. Yep. > Probably we'll need tools/lib/symbols/, tools/lib/trace/parser/ things > like that, I'll start with the symbols part, using a samples/ file I > already wrote. Nice, let me know when you have something ready so that we don't duplicate work. Also, I could give it a test run or two and all. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/