Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755767Ab0FCWDF (ORCPT ); Thu, 3 Jun 2010 18:03:05 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42823 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755452Ab0FCWDD (ORCPT ); Thu, 3 Jun 2010 18:03:03 -0400 Date: Thu, 3 Jun 2010 14:58:17 -0700 (PDT) From: Linus Torvalds To: Stephen Hemminger cc: Andrew Morton , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0 In-Reply-To: <20100603144913.24828629@nehalam> Message-ID: References: <20100603101501.5e5d7148@nehalam> <20100603120313.10a73b20@nehalam> <20100603144913.24828629@nehalam> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 32 On Thu, 3 Jun 2010, Stephen Hemminger wrote: > > It seems it isn't related to initial jiffies. > Initializing the values (though a good idea), doesn't solve the > problem. Still failed. So dazed and confused, went back and reran > kernel with jiffies=0 showed same problem, just took multiple boots > to reproduce. Ahh, ok. That really ends up limiting us. At least having a "it's related to jiffy wraparound" was a big clue. > So still a race that shows up with KVM (fast floppy?) and manifests > as floppy_ready or reset_interrupt OOPS. Yes, it's quite possible that the Linux floppy driver is simply broken by any floppy device that basically responds immediately to a command with an interrupt. And considering how few people use floppies, I do expect that driver to get _worse_ rather than better in the future. Don't get me wrong - I'm sure it could be fixed. I'm just not sure that anybody is going to spend the effort. I'd love to be proven wrong. Anybody? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/