Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756779Ab0FCXSW (ORCPT ); Thu, 3 Jun 2010 19:18:22 -0400 Received: from smtp-out.google.com ([74.125.121.35]:16555 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756562Ab0FCXSN (ORCPT ); Thu, 3 Jun 2010 19:18:13 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=Vv5jRiCubUrlf805L/df3kVlPYgawWWmHwM570fQlFtYiHUpQgItTZEUkLC+/mZ7/ nGr3MHG/lItcCH4qWOa3A== Date: Thu, 3 Jun 2010 16:18:06 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Oleg Nesterov cc: KOSAKI Motohiro , "Luis Claudio R. Goncalves" , LKML , linux-mm , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin Subject: Re: [PATCH 08/12] oom: dump_tasks() use find_lock_task_mm() too In-Reply-To: <20100603220103.GA8511@redhat.com> Message-ID: References: <20100603135106.7247.A69D9226@jp.fujitsu.com> <20100603152350.725F.A69D9226@jp.fujitsu.com> <20100603152652.GA8743@redhat.com> <20100603220103.GA8511@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 26 On Fri, 4 Jun 2010, Oleg Nesterov wrote: > On 06/03, David Rientjes wrote: > > > > On Thu, 3 Jun 2010, Oleg Nesterov wrote: > > > > > (off-topic) > > > > > > out_of_memory() calls dump_header()->dump_tasks() lockless, we > > > need tasklist. > > forgot to mention, __out_of_memory() too. > > > Already fixed in my rewrite patchset, as most of these things are. Sigh. > > In 3/18, without any note in the changelog. Another minor thing > which can be fixed before rewrite. > It's _not_ rc material, we don't merge patches into rc kernels where the end result is panic() in all cases anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/