Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756566Ab0FCX0m (ORCPT ); Thu, 3 Jun 2010 19:26:42 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34323 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772Ab0FCX0k (ORCPT ); Thu, 3 Jun 2010 19:26:40 -0400 Date: Thu, 3 Jun 2010 16:21:55 -0700 (PDT) From: Linus Torvalds To: Stephen Hemminger cc: Andrew Morton , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0 In-Reply-To: <20100603161513.60370e98@nehalam> Message-ID: References: <20100603101501.5e5d7148@nehalam> <20100603120313.10a73b20@nehalam> <20100603144913.24828629@nehalam> <20100603161513.60370e98@nehalam> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 21 On Thu, 3 Jun 2010, Stephen Hemminger wrote: > > Maybe putting all back together in a threaded_irq would be safest. Yes. That floppy driver could easily be a good case for using those threaded irq's. The problem, of course, is to find somebody motivated enough. The code-base really is pretty dang ugly, and it might be hard to do it incrementally, I think. (And starting from scratch is likely not a great idea either - while _some_ of the ugliness comes from the odd irq-driven state machine code, a lot of it also comes from trying to handle all those floppy formats etc) Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/