Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757347Ab0FDDqd (ORCPT ); Thu, 3 Jun 2010 23:46:33 -0400 Received: from mail-gw0-f46.google.com ([74.125.83.46]:43597 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757007Ab0FDDqb (ORCPT ); Thu, 3 Jun 2010 23:46:31 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=GSyEq/RjAcLSgTq2915nSwJLa1LjBS38X0EvrwvTr9yYAuV4s1Rqsf7Tlq9oBBQGms 7q6zJLMc6Hjvb4BiAut/ELZZv58e+5FSR0F/3D4cM497ruMpF5U/E2OOBM9pT1mUSpqe FkEkkhVBjO0VmqM+PrcDErvTmWgTwgaed1b20= MIME-Version: 1.0 In-Reply-To: <1275623379.1515.1.camel@eight.analog.com> References: <1275623379.1515.1.camel@eight.analog.com> From: Mike Frysinger Date: Thu, 3 Jun 2010 23:46:10 -0400 Message-ID: Subject: Re: [Uclinux-dist-devel] [PATCH v5] regulator: new drivers for AD5398 and AD5821 To: sonic zhang Cc: Mark Brown , Liam Girdwood , uclinux-dist-devel , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 13 On Thu, Jun 3, 2010 at 23:49, sonic zhang wrote: > +static const struct regulator_ops ad5398_ops = { > +static const struct regulator_desc ad5398_reg = { when i said these should be const, this isnt something that can start with the drivers. the core needs to be fixed first. otherwise these simply trigger warnings. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/