Date: Thu, 3 Jun 2010 21:42:23 -0700
From: Philip Langdale <philipl@overt.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, adq_dvb@lidskialf.net,
       "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: make sdhci work with ricoh mmc controller
Message-ID: <20100603214223.61325b5d@fido5>
In-Reply-To: <1275586531.2594.3.camel@maxim-laptop>
References: <1275516180.30272.4.camel@maxim-laptop>
	<1275527787-3783-1-git-send-email-maximlevitsky@gmail.com>
	<20100603091113.7b1d6fc0@fido5>
	<1275582709.2563.19.camel@maxim-laptop>
	<20100603093914.3397ac42@fido5>
	<20100603100510.37d02c2b@fido5>
	<1275586531.2594.3.camel@maxim-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2255
Lines: 55

On Thu, 03 Jun 2010 20:35:31 +0300
Maxim Levitsky <maximlevitsky@gmail.com> wrote:

> On Thu, 2010-06-03 at 10:05 -0700, Philip Langdale wrote: 
> > On Thu, 3 Jun 2010 09:39:14 -0700
> > Philip Langdale <philipl@overt.org> wrote:
> > 
> > > > > 
> > > > > Have you been able to establish if 4bit and high-speed
> > > > > operations work correctly through the MMC controller? I note
> > > > > that you didn't set SDHCI_CAN_DO_HISPD.
> > > > Didn't test that yet, will do.
> > > > I hope my MMCPlus card can do high-speed.
> > > 
> > > I should get a chance today to test this as well; I'll let you
> > > know what I see.
> > > 
> > 
> > Ok, I was able to try it out and setting HISPD works and 4bit seems
> > to work too. My MMCplus cards run at the same speed with either
> > controller.
> I too confirm that.

On this subject:

1) Would it make sense to have the hard-coded caps reflect the full
set of caps you see on the sdhci side?

2) We ought to be able to set the MMC high-speed flag for this
controller; I've tried it out and it works fine. The default sdhci
code will never set this flag. I think it would need to an additional
quirk. Pierre argued against setting it on the basis that SD high speed
has slightly different timings; I haven't seen hardware where this
has been an issue.

> However that suspend/resume race is tough one.
> The problem seems that controller doesn't like both devices to be
> poked at same time, and normally they won't, but here on resume both
> are tested for a card, and this is done asynchronously by mmc core.
> 
> I will get to bottom of this sooner or later (I hope).

Hmm. So, if the issue is the test, then you should be able to serialize
in mmc core instead of forcing sync resume in general. An ugly way would
be a quirk that says to serialize all card tests if the controller is
present in the system. In practice it would be fine as systems won't
have arbitrary other sdhci controllers if they have this ricoh mmc
thing. But yes, it isn't clean. :-P

--phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/