Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229Ab0FDLwl (ORCPT ); Fri, 4 Jun 2010 07:52:41 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:47542 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753915Ab0FDLwk (ORCPT ); Fri, 4 Jun 2010 07:52:40 -0400 Date: Fri, 4 Jun 2010 13:00:50 +0100 From: Alan Cox To: Masayuki Ohtake Cc: LKML , Andrew , Intel OTC , "Wang, Qi" , "Wang, Yong Y" Subject: Re: [PATCH] Topcliff PHUB: Generate PacketHub driver Message-ID: <20100604130050.2b555944@lxorguk.ukuu.org.uk> In-Reply-To: <4C08D268.6000404@dsn.okisemi.com> References: <4C08D268.6000404@dsn.okisemi.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 17 > +/*! > + * @ingroup PHUB_PCILayerAPI > + * @fn static void __exit pch_phub_pci_exit(void) > + * @brief Provides the functionality of exiting the module > + * */ Can we please do something about all this stuff first so the code is easier to review by those not familiar with the kernel format. I sent a bit of code out last time that did most of the work Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/