Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754351Ab0FDQum (ORCPT ); Fri, 4 Jun 2010 12:50:42 -0400 Received: from buzzloop.caiaq.de ([212.112.241.133]:52987 "EHLO buzzloop.caiaq.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410Ab0FDQul (ORCPT ); Fri, 4 Jun 2010 12:50:41 -0400 Date: Fri, 4 Jun 2010 18:50:37 +0200 From: Daniel Mack To: Greg KH Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Magnus Damm , Alan Stern , Randy Dunlap , linux-pm@lists.linux-foundation.org Subject: Re: [PATCH] drivers/base/power: be more verbose in device_pm_add() Message-ID: <20100604165037.GG2695@buzzloop.caiaq.de> References: <1275653834-9132-1-git-send-email-daniel@caiaq.de> <20100604164527.GA27034@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100604164527.GA27034@suse.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1771 Lines: 43 On Fri, Jun 04, 2010 at 09:45:27AM -0700, Greg KH wrote: > On Fri, Jun 04, 2010 at 02:17:14PM +0200, Daniel Mack wrote: > > If a parentless device was added during a PM transaction, developers > > might want to know which device caused the troube. Hence, output the > > kobject's name in this case. > > > > Signed-off-by: Daniel Mack > > Cc: Rafael J. Wysocki > > Cc: Len Brown > > Cc: Greg Kroah-Hartman > > Cc: Magnus Damm > > Cc: Alan Stern > > Cc: Randy Dunlap > > Cc: linux-pm@lists.linux-foundation.org > > --- > > drivers/base/power/main.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > > index 941fcb8..9e9fe6a 100644 > > --- a/drivers/base/power/main.c > > +++ b/drivers/base/power/main.c > > @@ -98,7 +98,7 @@ void device_pm_add(struct device *dev) > > * transition is in progress in order to avoid leaving them > > * unhandled down the road > > */ > > - dev_WARN(dev, "Parentless device registered during a PM transaction\n"); > > + dev_WARN(dev, "Parentless device registered during a PM transaction: %s\n", kobject_name(&dev->kobj)); > > Doesn'tthe dev_WARN call already print the name of the device? Why > print it twice? Erm, no it didn't. Should it have? This is what I saw: [ 0.880646] Parentless device registered during a PM transaction Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/