From: Arnd Bergmann <arnd@arndb.de>
To: Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com>
Subject: Re: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()
Date: Sat, 5 Jun 2010 12:07:39 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; )
Cc: LKML <linux-kernel@vger.kernel.org>, gregkh@suse.de, bzolnier@gmail.com,
       roel.kluin@gmail.com, devel@driverdev.osuosl.org
References: <1275712909.8509.25.camel@debian-hell>
In-Reply-To: <1275712909.8509.25.camel@debian-hell>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201006051207.40040.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 21

On Saturday 05 June 2010, Giangiacomo Mariotti wrote:
> This debug printk is only useful if you're debugging the staging drivers
> 2860 e 2870, but, if you're just using them, it becomes really annoying, because
> it uselessly clobbers the kernel log. I guess this patch shouldn't really get merged,
> but it's more like a request to remove these annoying debugging messages for normal users.
> If I get any suggestion on how to implement this in a way acceptable to get it merged, I'll
> be happy to create the "good" version  of the patch.

Ideally, drivers should not have their own debugging macros like this, but
instead use the kernel's own pr_debug() and (preferrably) dev_dbg() macros,
which are disabled by default.
For many of these debugging outputs, it's even better to kill them entirely
instead of converting to dev_dbg().
Do not put the line in comments though.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/