Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409Ab0FGVXb (ORCPT ); Mon, 7 Jun 2010 17:23:31 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55633 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750Ab0FGVX3 (ORCPT ); Mon, 7 Jun 2010 17:23:29 -0400 Date: Mon, 7 Jun 2010 14:17:23 -0700 (PDT) From: Linus Torvalds To: David Woodhouse cc: Al Viro , Dave Airlie , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List Subject: Re: [git pull] drm fixes In-Reply-To: <1275939165.17903.5100.camel@macbook.infradead.org> Message-ID: References: <20100607182640.GL31073@ZenIV.linux.org.uk> <1275939165.17903.5100.camel@macbook.infradead.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 38 On Mon, 7 Jun 2010, David Woodhouse wrote: > > The fix is fairly trivial. There's a "big" patch to fs/jffs2/dir.c which > accounts for the bulk of my pull request, but if you look harder you'll > see it's mostly just a bunch of removing 'return ret;' and adding > 'goto fail;' so the error cleanup happens properly. So that's the part I'm worried about. I'm going to be hardnosed, but I'm _not_ going to so hardnosed as to worry about some oneliner DocBook patch. It's not about being anal to quite that degree, that would be silly. But the dir.c change is what I end up worrying about. It's not at all clear why it's good to change jffs2_clear_inode(inode); into make_bad_inode(inode); iput(inode); and that changelog doesn't really explain it either ("fix leak"? Ok, I can see the iput() fixing the leak - but you also did that jffs2_clear_inode() change, and that has no explanation what-so-ever. So is this a safe thing that definitely fixes a serious bug? I am left with no good way to judge. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/