Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753399Ab0FGVj6 (ORCPT ); Mon, 7 Jun 2010 17:39:58 -0400 Received: from casper.infradead.org ([85.118.1.10]:48556 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077Ab0FGVj5 (ORCPT ); Mon, 7 Jun 2010 17:39:57 -0400 Subject: Re: [git pull] drm fixes From: David Woodhouse To: Linus Torvalds Cc: Al Viro , Dave Airlie , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List In-Reply-To: References: <20100607182640.GL31073@ZenIV.linux.org.uk> <1275939165.17903.5100.camel@macbook.infradead.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 Jun 2010 22:39:28 +0100 Message-ID: <1275946768.17903.5126.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.30.1.2 (2.30.1.2-6.fc13) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 20 On Mon, 2010-06-07 at 14:17 -0700, Linus Torvalds wrote: > and that changelog doesn't really explain it either ("fix leak"? Ok, I can > see the iput() fixing the leak - but you also did that jffs2_clear_inode() > change, and that has no explanation what-so-ever. jffs2_clear_inode() is the file system's ->clear_inode method, so it gets called from the VFS when the inode is destroyed, after iput(). I suppose that ought to have been a clue, right from the very beginning, that we should never have been calling it directly on our error paths. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/