Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329Ab0FGVnr (ORCPT ); Mon, 7 Jun 2010 17:43:47 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50997 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925Ab0FGVnq (ORCPT ); Mon, 7 Jun 2010 17:43:46 -0400 Date: Mon, 7 Jun 2010 14:38:09 -0700 (PDT) From: Linus Torvalds To: Al Viro cc: David Woodhouse , Dave Airlie , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List Subject: Re: [git pull] drm fixes In-Reply-To: <20100607213310.GO31073@ZenIV.linux.org.uk> Message-ID: References: <20100607182640.GL31073@ZenIV.linux.org.uk> <1275939165.17903.5100.camel@macbook.infradead.org> <20100607213310.GO31073@ZenIV.linux.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 39 On Mon, 7 Jun 2010, Al Viro wrote: > On Mon, Jun 07, 2010 at 02:17:23PM -0700, Linus Torvalds wrote: > > jffs2_clear_inode(inode); > > > > into > > > > make_bad_inode(inode); > > iput(inode); > > > > and that changelog doesn't really explain it either ("fix leak"? Ok, I can > > see the iput() fixing the leak - but you also did that jffs2_clear_inode() > > change, and that has no explanation what-so-ever. > > The final iput() calls ->clear_inode() (jffs2_clear_inode in case of jffs2) > and the inode has just been created, with no other in-core references > existing. Basically, that call was the only part of (required) iput() that > _was_ done there ;-) > > FWIW, what's happening around ->clear_inode()/->delete_inode()/->drop_inode() > is a mess. This leak got found when I'd been looking through that crap; > results of sanitizing are in #evict_inode (vfs-2.6.git). I'm going to shift > that into for-next tomorrow, assuming it survives local beating. For now > I've just pulled jffs2-fixes in it... Ok, a changelog like that would have been a good thing. Not that I usually care, but now that I'm in careful mode, I do end up looking at things like this, and a good changelog would have goen m uch further in convincing me that the "goto fail" changes really were just about fixing the leak, and that there wasn't some other change hidden in the same commit. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/