Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754382Ab0FHHXw (ORCPT ); Tue, 8 Jun 2010 03:23:52 -0400 Received: from zmta01.cabocomm.dk ([193.200.44.52]:59785 "EHLO zmta01.irigo.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083Ab0FHHXu (ORCPT ); Tue, 8 Jun 2010 03:23:50 -0400 Subject: Re: [RFC][PATCH] irq: support IRQ_NESTED_THREAD with non-threaded interrupt handlers From: Esben Haabendal To: Thomas Gleixner Cc: Esben Haabendal , linuxppc-dev@ozlabs.org, Marc Zyngier , LKML , Ingo Molnar , joachim.eastwood@jotron.com, Peter Zijlstra , David Miller In-Reply-To: References: <1275686352.2970.2.camel@eha.doredevelopment.dk> <20100605151031.2d562268@hina.wild-wind.fr.eu.org> <1275914058.2818.8.camel@eha.doredevelopment.dk> Content-Type: text/plain; charset="UTF-8" Organization: =?ISO-8859-1?Q?Dor=E9Development?= ApS Date: Tue, 08 Jun 2010 09:23:40 +0200 Message-ID: <1275981820.2870.74.camel@eha.doredevelopment.dk> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 32 On Tue, 2010-06-08 at 08:58 +0200, Thomas Gleixner wrote: > On Mon, 7 Jun 2010, Esben Haabendal wrote: > > > On Mon, Jun 7, 2010 at 5:06 PM, Thomas Gleixner wrote: > > > > > Maybe you understand now, why I was pretty sure upfront, that your > > > approach was wrong even without knowing all the gory details ? :) > > > > I understand. There is a better solution, which is to use threaded > > interrupts where needed. > > FWIW, it just occured to me, that the only reason why the > disable_irq_nosysnc() trips up on the in_atomic() check is your > fiddling with the nested irq dispatcher. > > If you just would have changed the phy driver to > request_irq_any_context() it would have simply worked out of the box, > without any need to remove buslock and changing genirq code at all. > > That would not give you the advantage of getting rid of the two > additional I2C transfers, but that's nn optimzation not a functional > requirement. Now, that is good news. Thanks! /Esben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/