Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755660Ab0FHQhc (ORCPT ); Tue, 8 Jun 2010 12:37:32 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:62281 "EHLO ausxipps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755492Ab0FHQhb convert rfc822-to-8bit (ORCPT ); Tue, 8 Jun 2010 12:37:31 -0400 X-Loopcount0: from 10.166.62.177 From: To: CC: , , , Date: Tue, 8 Jun 2010 11:33:39 -0500 Subject: RE: Dell Studio 1555 eject key does not work ( small patch to fix included ) Thread-Topic: Dell Studio 1555 eject key does not work ( small patch to fix included ) Thread-Index: AcsG+YLSSB+1oduvShCxSLrIN0T2cAALqvxQ Message-ID: <57DF5FDC2DC0634FA2A310BC5B81A68D01DF54BF73@AUSX7MCPC108.AMER.DELL.COM> References: <20100602213429.GA14866@srcf.ucam.org> <57DF5FDC2DC0634FA2A310BC5B81A68D01DF4CD01E@AUSX7MCPC108.AMER.DELL.COM> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginalArrivalTime: 08 Jun 2010 16:37:23.0685 (UTC) FILETIME=[DF502950:01CB0728] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3698 Lines: 129 Hi Islam Amer I have asked feedback from the BIOS team and will update this thread as soon as I get it. Thanks.. --rez Rezwanul Kabir Dell Linux Development 512-725-0766 >-----Original Message----- >From: Islam Amer [mailto:pharon@gmail.com] >Sent: Tuesday, June 08, 2010 5:58 AM >To: Kabir, Rezwanul >Cc: mjg59@srcf.ucam.org; linux-kernel@vger.kernel.org; >platform-driver-x86@vger.kernel.org; akpm@linux-foundation.org >Subject: Re: Dell Studio 1555 eject key does not work ( small >patch to fix included ) > >Dear Rezwanul, > >I have been using this fix for quite some time without any >visible ill effects on the other keys or the system in general. >Of course it would be necessary to get feedback from other dell users. > >Thanks. > >On Thu, Jun 3, 2010 at 11:16 PM, Islam Amer wrote: >> Hello, >> >> I suspected the same about dell_new_hk_type, but I am confused that >> the rest of the fn keys work just fine out of the box. The >only button >> that didn't work was the eject key. >> >> Attached is the dmidecode output. >> >> Thanks >> >> On Thu, Jun 3, 2010 at 5:57 AM, ? wrote: >>> >>>>Hi Rez, >>>> >>>>Any thoughts on this? >>>> >>> >>> >>> ?From the discussion below, it seems that this system does not >>> implement the new WMI scheme ( which is when >dell_new_hk_type=true is >>> set). So, at issue here is the legacy code. Without knowing exactly >>> why BIOS would behave differently in this particular case, >the fix seems arbitrary. Let me see if I can get hold of the >BIOS developer(if possible) and provide feedback in this thread. >>> >>> Islam Amer >>> >>> ? Can you attach dmidecode output from the system here? >>> >>> Thanks.. >>> ? --rez >>> >>> >>> >>> >>> >>>>On Thu, Jun 03, 2010 at 01:14:09AM +0400, Islam Amer wrote >>>>> Hello, >>>>> >>>>> Pressing the eject key on my Dell Studio 1555 does not work >>>>and dmesg >>>>> produces this message : >>>>> dell-wmi: Unknown key 0 pressed >>>>> >>>>> Adding a debugging printk in dell-wmi.c after line 222 like this : >>>>> >>>>> printk(KERN_INFO "dell:wmi 0x%x , 0x%x \n", buffer_entry[1], >>>>> buffer_entry[2]); >>>>> >>>>> dmesg now shows : >>>>> >>>>> dell:wmi 0x0 , 0xe009 >>>>> dell-wmi: Unknown key 0 pressed >>>>> >>>>> So for some reason buffer_entry[1] is used although it is empty. >>>>> >>>>> Falling back to buffer_entry[2] in case buffer_entry[1] is 0x0 >>>>> makes the button work. >>>>> >>>>> I suspect it might be better to fix the "dell_new_hk_type" logic >>>>> though >>>>> >>>>> I had submitted this as >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=16075 but >repeating the >>>>> information and patch here as per Andrew Morton's suggestion. >>>>> >>>>> >>>>> Thanks. >>>>> >>>>> --- >>>>linux-sidux-2.6-2.6.34/drivers/platform/x86/dell-wmi.c.orig >>>>2010-06-03 >>>>> 01:02:17.418824168 +0400 >>>>> +++ linux-sidux-2.6-2.6.34/drivers/platform/x86/dell-wmi.c >>>>2010-06-03 >>>>> 01:01:40.641833249 +0400 >>>>> @@ -221,7 +221,7 @@ static void dell_wmi_notify(u32 value, v >>>>> ? ? ? ? ? ? ? ? ? ? ?return; >>>>> ? ? ? ? ? ? ?} >>>>> >>>>> - ? ? ? ? ? ?if (dell_new_hk_type) >>>>> + ? ? ? ? ? ?if (dell_new_hk_type || buffer_entry[1] == 0x0) >>>>> ? ? ? ? ? ? ? ? ? ? ?reported_key = (int)buffer_entry[2]; >>>>> ? ? ? ? ? ? ?else >>>>> ? ? ? ? ? ? ? ? ? ? ?reported_key = (int)buffer_entry[1] & 0xffff; >>>>> >>>>-- >>>>Matthew Garrett | mjg59@srcf.ucam.org >>>> >> >-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/