Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197Ab0FIFcZ (ORCPT ); Wed, 9 Jun 2010 01:32:25 -0400 Received: from mail.vyatta.com ([76.74.103.46]:58484 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734Ab0FIFcQ (ORCPT ); Wed, 9 Jun 2010 01:32:16 -0400 Date: Tue, 8 Jun 2010 22:32:11 -0700 From: Stephen Hemminger To: Linus Torvalds Cc: Andrew Morton , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0 Message-ID: <20100608223211.0c0bb1bc@nehalam> In-Reply-To: References: <20100603101501.5e5d7148@nehalam> <20100603120313.10a73b20@nehalam> <20100603144913.24828629@nehalam> <20100603161513.60370e98@nehalam> Organization: Vyatta X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 30 On Thu, 3 Jun 2010 16:21:55 -0700 (PDT) Linus Torvalds wrote: > > > On Thu, 3 Jun 2010, Stephen Hemminger wrote: > > > > Maybe putting all back together in a threaded_irq would be safest. > > Yes. That floppy driver could easily be a good case for using those > threaded irq's. The problem, of course, is to find somebody motivated > enough. The code-base really is pretty dang ugly, and it might be hard to > do it incrementally, I think. > > (And starting from scratch is likely not a great idea either - while > _some_ of the ugliness comes from the odd irq-driven state machine code, a > lot of it also comes from trying to handle all those floppy formats etc) > > Linus I have fixes to stop the panic, but will hold off until 2.6.36. For now want to make sure that there is no chance of causing worse problems on real hardware. There is no reason there should ever be I/O error's and panic when running on virtual hardware. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/