Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572Ab0FIHgd (ORCPT ); Wed, 9 Jun 2010 03:36:33 -0400 Received: from mga14.intel.com ([143.182.124.37]:22234 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370Ab0FIHgb convert rfc822-to-8bit (ORCPT ); Wed, 9 Jun 2010 03:36:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.53,389,1272870000"; d="scan'208";a="286754692" From: "Xin, Xiaohui" To: Eric Dumazet CC: "netdev@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mst@redhat.com" , "mingo@elte.hu" , "davem@davemloft.net" , "herbert@gondor.apana.org.au" , "jdike@linux.intel.com" Date: Wed, 9 Jun 2010 15:34:16 +0800 Subject: RE: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. Thread-Topic: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. Thread-Index: AcsEvvfRwC+bkk/FS1SoW7z09M2PswC5xHYg Message-ID: References: <1275732899-5423-1-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-2-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-3-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-4-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-5-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-6-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-7-git-send-email-xiaohui.xin@intel.com> <1275732899-5423-8-git-send-email-xiaohui.xin@intel.com> <1275749604.5238.239.camel@edumazet-laptop> In-Reply-To: <1275749604.5238.239.camel@edumazet-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 33 >-----Original Message----- >From: Eric Dumazet [mailto:eric.dumazet@gmail.com] >Sent: Saturday, June 05, 2010 10:53 PM >To: Xin, Xiaohui >Cc: netdev@vger.kernel.org; kvm@vger.kernel.org; linux-kernel@vger.kernel.org; >mst@redhat.com; mingo@elte.hu; davem@davemloft.net; herbert@gondor.apana.org.au; >jdike@linux.intel.com >Subject: Re: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. > >Le samedi 05 juin 2010 ? 18:14 +0800, xiaohui.xin@intel.com a ?crit : >> From: Xin Xiaohui >> child->fclone = SKB_FCLONE_UNAVAILABLE; >> } >> + /* Record the external buffer info in this field. It's not so good, >> + * but we cannot find another place easily. >> + */ >> + shinfo->destructor_arg = ext_page; >> + > > >Yes this is a big problem, its basically using a cache line that was not >touched before. > Did your patch which moves destructor_arg before frags[] also fix this? Thanks Xiaohui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/